SHS-4946: Implement update to Spotlight color values #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es and update reference to spotlight
… shs-4946--spotlight-color-values-update
cienvaras
added
Passes code review
Passes functional review
and removed
Needs review
labels
joegl
pushed a commit
that referenced
this pull request
Mar 12, 2024
* feat(shs-4945): remove tertiary-reversed-darken-10 from the color mapping files (#1467) * feat(shs-4946): remove spotlight-lighten-8 from the color mapping files and update reference to spotlight (#1468) * SHS-5498: Shortcut menu is not displaying in admin toolbar for site editors when they log in (#1465) * feat(shs-5498): open shortcuts toolbar menu by default on user login * feat(shs-5498): only open shortcuts if it's not already selected on login * feat(shs-5497): respect reduced motion for nav caret animation (#1469) * SHS-5504: Prevent JS error when link is absent in vertical linked cards (#1471) * chore(shs-5504): add prettier config to match eslint * SHS-5501: Add "Raised Cards" and "Uniform Height" options to Private Collection paragraph (#1466) * feat(shs-5501): add Uniform Height and Raised Cards fields to private collection component * feat(shs-5501): add template for private collection paragraphs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
spotlight-lighten-8are replaced with references tospotlight.spotlight-lighten-8from the color mapping files.Need Review By (Date)
3/13
Urgency
low
Steps to Test
spotlight-lighten-8is no longer in any color mapping file and is not being referenced anywhere.Color Bandas theLightoption color is close to theSpotlight-BG(spotlight) colorPR Checklist